Skip to content

Restored functionality to pipeline, clarified entrypoint, and improved documentation #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjia1 merged 9 commits into from
Jul 18, 2025
Merged

Restored functionality to pipeline, clarified entrypoint, and improved documentation #55

jjia1 merged 9 commits into from
Jul 18, 2025

Conversation

@jjia1
Copy link
Collaborator

@jjia1 jjia1 commented Jul 18, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Current pipeline is broken and does not actually run properly from start to finish.

Issue Number: N/A

What is the new behavior?

Two parts:

  1. takes mentee resumes from directory as input and outputs JSON file of all matches
  2. allowed full overwrite to run process (text extraction, mentor profile summarization, professor title ranking, csv construction, index generation, and matching).

Other information

@jjia1 jjia1 self-assigned this Jul 18, 2025
@jjia1 jjia1 added bug Something isn't working critical labels Jul 18, 2025
@jylee-bcm
Copy link
Collaborator

jylee-bcm commented Jul 18, 2025

Good job, looks much cleaner.

I have a question: What's the functionality of uv command in this project? does it speed up? is it usable in skyriver?

@jjia1
Copy link
Collaborator Author

jjia1 commented Jul 18, 2025

Good job, looks much cleaner.

I have a question: What's the functionality of uv command in this project? does it speed up? is it usable in skyriver?

I use uv as a fast package manager. I've found it to be faster than just regular pip when dealing with dependency issues.

jylee-bcm
jylee-bcm approved these changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@jylee-bcm jylee-bcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@jjia1 jjia1 merged commit aa3252e into main Jul 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jylee-bcm jylee-bcm jylee-bcm approved these changes

Assignees

@jjia1 jjia1

Labels

bug Something isn't working critical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjia1 @jylee-bcm